Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event being dropped if property value is custom object #798

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented Sep 8, 2022

Mixpanel does not support saving a custom class object as a property. Currently if you happened to save a custom object as a property, it will cause the event being silently dropped. The PR will prevent the event from being dropped if properties contain custom objects, however, the custom object still can't be sent to Mixpanel and will fall back to a null value. If you want to send property values from the custom class object or nested collection type, you need to flatten them and convert them as Mixpanel Supported Data Types.

@zihejia zihejia added the bug label Sep 8, 2022
Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zihejia zihejia merged commit 1536742 into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants